Disallow scalar conversation for non-0D arrays #2223
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2223/index.html |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_103 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_108 ran successfully. |
| cdef inline void _check_0d_scalar_conversion(object usm_ary) except *: | ||
| "Raise TypeError if array cannot be converted to a Python scalar" | ||
| if (usm_ary.ndim != 0): | ||
| raise TypeError( |
There was a problem hiding this comment.
| raise TypeError( | |
| raise ValueError( |
There was a problem hiding this comment.
I guess NumPy raises a TypeError but this really seems like a ValueError to me
There was a problem hiding this comment.
usm_ary.ndim != 0 means the object is not scalar-like and does not implement the scalar conversional protocol so TypeError is more appropriate than ValueError
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
aside from minor comments this LGTM
vlad-perevezentsev
changed the title
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_109 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_110 ran successfully. |
4 participants
This PR aligns
usm_ndarrayscalar conversion semantics with the Python Array API by allowing scalar conversion only for 0D usm_ndarraysConversions to Python numeric scalars via
int,float,complex,bool, and their corresponding methods (__int__,_float__,__complex__, bool) now raiseTypeErrorwhen applied to usm_ndarrays withndim !=0`